Supports any custom command extension directly #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s like 'getTextWithCommandExtension' 'dragAndDropWithCommandExtension'
|
|
I see the logic in this solution, but it also feels a bit inconsistent. New kind command extensions possibly made by others may stay outside this project, so we won't see unique solutions or examples. It would be better to include the new command as a proper commandExtension, with a description in the README and an example in this folder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call any custom command extension directly without adding new commands like 'getTextWithCommandExtension' 'dragAndDropWithCommandExtension'.
Once introduce a new extension in Flutter App like 'lib/drag_commands.dart' , it can be invoked from appium client immediately without any change to appium-flutter-driver.
example: